Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use another method of FIPS validation (fips-detect) #3363

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

hawkowl
Copy link
Collaborator

@hawkowl hawkowl commented Jan 22, 2024

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-5136

What this PR does / why we need it:

Use an alternative method (fips-detect) which validates the binary directly.

Test plan for issue:

Should be covered by CI?

Is there any documentation that needs to be updated for this PR?

N/A

Copy link

Please rebase pull request.

@github-actions github-actions bot added needs-rebase branch needs a rebase and removed ready-for-review labels Jan 28, 2024
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Jan 28, 2024
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. LGTM

Copy link
Contributor

@jaitaiwan jaitaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hawkowl hawkowl merged commit b6e1b07 into Azure:master Feb 1, 2024
18 checks passed
@hawkowl hawkowl deleted the hawkowl/ARO-5136 branch February 1, 2024 02:21
mociarain pushed a commit that referenced this pull request Feb 8, 2024
* Use another method of FIPS validation (fips-detect)
mociarain pushed a commit that referenced this pull request Mar 18, 2024
* Use another method of FIPS validation (fips-detect)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code ready-for-review skippy pull requests raised by member of Team Skippy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants