-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use another method of FIPS validation (fips-detect) #3363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
dofinn
as code owners
January 22, 2024 20:44
hawkowl
added
ready-for-review
go
Pull requests that update Go code
skippy
pull requests raised by member of Team Skippy
labels
Jan 22, 2024
Please rebase pull request. |
github-actions
bot
added
needs-rebase
branch needs a rebase
and removed
ready-for-review
labels
Jan 28, 2024
hawkowl
force-pushed
the
hawkowl/ARO-5136
branch
from
January 28, 2024 23:55
7c59f92
to
fbe5b59
Compare
mociarain
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change. LGTM
mociarain
approved these changes
Jan 30, 2024
jaitaiwan
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mociarain
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Use another method of FIPS validation (fips-detect)
mociarain
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Use another method of FIPS validation (fips-detect)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
go
Pull requests that update Go code
ready-for-review
skippy
pull requests raised by member of Team Skippy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-5136
What this PR does / why we need it:
Use an alternative method (fips-detect) which validates the binary directly.
Test plan for issue:
Should be covered by CI?
Is there any documentation that needs to be updated for this PR?
N/A